Not only is having too many comments on your PRs bad for you, but so is not leaving comments on other people's PRs. Both are metrics used
replyI'd leave lots of comments out of spite whenever I would feel my PRs had been treated unfairly. If I am going down, you all are coming with me.
replyI specifically look at the quality / substance of the comments when I'm reviewing someone for promo/transfer/fire.
replyWelcome to Amazon, you'll fit right in.
reply> 2. Having Less comments on their PRs: for some drastically dumb reason, having a PR thoroughly reviewed
replyI'm very far away from liking Amazon's engineering culture and general work culture, but having PRs with countless of discussions and feedback on it does signal that you've done a lot of work without collaborating with others before doing the work. Generally in teams that work well together and build great software, the PRs tend to have very little on them, as most of the issues were resolved while designing together with others.
If the review tooling is any good, getting the code somewhere it can see it is a convenient way for people to give and receive feedback. As the saying goes, the system is what it does!
reply(And/but yes/no, I have never worked at NAGFAM...)
I've been involved in so many CRs where I've given feedback over 10 revs, then the submitter cancels the CR and files a new one, for the metrics.
replyEh I feel like there are some features where you just have to get in the weeds to even design it and the code review itself is part of the process of designing/figuring out the edge cases.
reply4. Don't work in the corporate equivalent of The Hunger Games.
replyAt least in the past the idea is you do the dance , vest and leave.
replyI missed my FAANG chance during the good years. No retirement for me!