Good thing that the article contains that warning, then.
replyNot really strong enough in a post about what to do in a codebase you’re not familiar with. In that situation you’re probably new to the team and organisation and likely to get off on the wrong foot with people if you assume their code “hurts”.
replyThe post is “here’s what I do”, not “here’s what you should do and then confront the team about the results.” It’s just showing you a quick way to get some insights. It’s not even guaranteeing it’s accurate, just showing you some things you might be able to draw some quick conclusions on.
replyI’m not sure why HN attracts this need to poke holes in interesting observations to “prove” they aren’t actually interesting.
It’s a bit reductive to call it poking holes. The author shared his valuable knowledge and I shared mine.
replydeleted
replyI found it interesting, that Git itself has built in similarity notion... when it packs objects, it groups files by path+size, runs delta cmpression to find which are close.
replyVery different from just counting commits - https://vectree.io/c/delta-compression-heuristics-and-packfi...
These commands are just about what files to start looking at to understand new codebase.
replyBetter for people to know they're just blindly copying tools and parroting their output as if it's automatically meaningfully. Any warning against that should be built into the individual, for their own sake
replyRight? Some of these comments feel “you gave me commands to run and I should be able to turn my brain off to interpret the outputs”. These aren’t newbie commands so the assumption would be that you kinda know what you’re doing at least a little bit. If not, then don’t run them… similar to how you should approach all commands/things from the internet
reply