VFW membership has declined because even with continuous wars for decades, the end of conscription has meant a lot fewer veterans. And many VFW halls functioned more like dive bars than anything else: nothing wrong with that, but not particularly attractive to most younger veterans.
I'm not as sure what point you're making about union staff. Surely there has been paid union staff for decades -- no real change there AFAIK -- and being "active" in the union doesn't mean you are doing paid staff work (though part time positions for retirees aren't that uncommon). There's a lot of stuff going in on a truly active union local that is definitely not paid work: being on the committee that builds the 4th of July parade float, organizing the games for the summer member picnic, organizing a group to go work in union colors at a Habitat for Humanity build, putting together care packages for sick members and sending groups to visit with shut-in retirees. You're right that, sadly, few locals are this active anymore, but it was once common.
While it's true that there are some positive factors causing it (e.g. housework has been made far easier through inventing/factorying/delivering/installing of appliances like vacuum cleaners, washing machines and dishwashers, and the world has just become easier and safer to be in for women through things such as reliable cars with power steering, mobile phone, and policemen who respond) there are a lot of negative factors that just push those time-rich, more society enriching-capable women into the world of work.
The main one being what I already mentioned: house prices force them to work to pay a bank back for paying a boomer a massive price for a house, to keep up with the other two-income house bids.