My time in submarines at sea just coincided with the last few years where smoking on submarines was still authorized.

It was awful, just awful. Especially in a space as cramped as a submarine and with a common ventilation system, you can't just put the smokers in a convenient spot all to themselves, they're always going to be near something the rest of the crew needs to access.