>NOBODY IS ATTACKING YOU
replySomehow this captures a lot of the culture for me.
Places I work at weed out for this. If people cant take peer review they sour the workday for others.
replyYou were not hired to write perfect code, relax.
Not true. I’ve attacked people before in the sense I was disgusted with the short cuts they took and the things they tried to get away with in the code.
replyI’ve seen the malicious deletion of features in order to stay hidden and I’ve called it out.
That's not always an attack though, at least in a constructive critical review, maybe the approach could be different, but I'm also talking about when people are leaving comments that are genuine, professional, and tone is fine. In your case, yes you are attacking them I suppose, even though you don't really need to, you just need to rejec the PR and comment "hey, are you sure this is right?" and substantiate it. Sometimes people don't realize.
reply