missing canaries more likely?
replyinsufficient tests that dont assert on the right things?
the existence of a test doesnt mean it catches the right thing
based on the description, id bet the COE action item will be to do a migration that enforces units are passed at the billing service level
theres no good reason for the billing service to make up its own units.
why would a test setting unit to Bytes fail and not MB, KB, or GB, and so on? That's like trying create a unit test for email opt-in, both true and false are valid values. It's up to the user to select the right one.
replyI'm not quite following your objection.. I'd expect a test that checks the multiplier is correct would detect orders of magnitude discrepancy. So if you're billing $x/byte you'd write a test for the billing thing that checks that, given y bytes, the bill is x*y.
reply[edit] This may need to be an integration test to be effective, there is a certain peril to mocking that could bite you here. But that's fine, we have the technology.
Technically, there could be a test. It could just be wrong!
replyIf a tree falls in the forest and nobody hears it...
reply[edit] Testing your tests, like testing your backups, is a good idea
Yes, test the negative case as well. eg if you get the system setup so you can log in, also make sure you get permission denied for bad login info.
reply