I didn't have to bother with the thermistor but some models need it yes. And some even have an i2c charge level module which is even harder to simulate though it can be done.
What is bad is using a resistor as the voltage drop will depend on the current being drawn by the device, but the article is not doing that (nor woudl I).
I have had phones on a charging dock for long periods. No issues.
Unless you have some budget small brand phone that was too cheap to be true, most phones are fine plugged in.
Still, it served our support team really well during the pandemic. They could test wifi setups at the office with different android versions even when they were in a country that was on lockdown themselves.
OpenSTF was great: https://github.com/openstf
I think it's now been replaced by DeviceFarmer: https://github.com/DeviceFarmer/stf
An ignored Galaxy S7 puffed up while sitting on a shelf, unplugged, in a climate-controlled room.
Some other devices have been fine for far longer periods so it's not like I'm thinking it's endemic or anything (my Sony PSP is still working well-enough with its still-flat lipo cell from 2008), but it's certainly a concern.