Tests would have caught it = https://github.com/rhysd/actionlint injection check
replyalso been a huge fan of zizmor (https://github.com/zizmorcore/zizmor) lately, basically: "am I going to footgun myself?"
replyI have been talking to people who want to autoreview and autoapprove "minor" AI prs. For security especially, I think if the models weren't enough to prevent the issues, they aren't enough to judge what is minor.
reply^^
replyAbsolutely.
Nothing in the PR jumps out as a red flag. Unless you know how the internals work, I suppose.
Shouldn't anyone reviewing such a PR know how the internals work?
replyNot anymore, it seems
replyAre you kidding? It's a very obvious case of quote injection. Not some subtle race condition or anything.
replyI think it's obvious too. I'd call out any case of `${{ }}` interpolation in a `run` block, and it's something I watch for in PRs. I also know other people don't watch for this, as I've corrected it about a hundred times. Over the last 10 years my average colleague understands less and less about injection or to watch for it at layer boundaries.
reply> Nothing in the PR jumps out as a red flag.
replyMade by AI?