upvote
> or recursion schemes

Fold is a recursion scheme

More complicated recursion schemes are progressively harder to read. Probably not great if you are not doing code golf

reply
I’ve never ever heard while described as a smell, or even slightly smelly.

Care to explain?

reply
I assume OP refers to the cases where "while" is used to re-implement existing operations... imagine finding code like this:

     i = 0
     while i != len(todo):
         process(todo[i])
         i = i + 1
sure, there may be a good reason to implement things this way (maybe "todo" grows during iteration?), but maybe not, and then the loop should be instead simplified to:

     for value in todo:
         process(value)
(as an aside, this is exactly the case where the comments are required: "# not using for loop because todo might grow" will make it clear it's an intentional decision and not hallucination or something written from ignorance)
reply
You can use iterators in a while loop like your for example, making it look as clean as the for.

I feel like this is a case of personal preference over actual issue.

reply
Probably because while is the source of many infinite loops, and because it’s sometimes faster and more rigorous to compute the length ahead of going into the loop.

That said, I personally don’t think it’s smelly at all.

reply
If you can smell it, there's something fishy in the neighborhood
reply