But...were they wrong? There is a difference between "edge case" and "cannot ever happen". I've seen this trend a lot lately where Claude suggests a lot of extra code to handle things that cannot possibly happen. Unless you ask it to, it won't trace the flow of data through the app to confirm the edge case actually exists, if local conditions appear to allow it. Then the developer lets it implement this crap without asking that one question, and I have to say YAGNI in the review.
replyI've seen so many software bugs in my career where when you traced execution, you'd find the code crashing in a block with the comment //this can never happen
replyThat’s not a bad thing though — what that means is that the original dev believed this could never happen and probably therefore could not decide exactly what the right way to handle the error is.
replyWhether they were wrong is a matter of perspective.
replyI think they were against over engineering because they were constantly firefighting bugs and didn’t have time to thoughtfully review.