upvote

points

by forbiddenvoid3 hours ago |
comments
upvoteby tracerbulletx3 hours ago|
[-]
If someone says PRs need to be small, and I say here are some examples of huge PRs that I think are good, do you think these are still bad? That is not remotely invalid.
reply
upvoteby Jtsummers3 hours ago|
parent|
next
[-]
Where did grey-area say they need to be small. As in an absolute? They didn't, you just assumed that's what they meant and then went off the rails in your response.
reply
upvoteby tracerbulletx3 hours ago|
parent|
[-]
The first 4 words? "Just ban large prs." A ban is pretty absolute language. He would have banned my example PRs clearly. Or maybe he wouldn't which is why I asked about them as examples. Because that is the obvious follow up. If you ban large PRs what are you losing? You're loosing big swing aggressive efforts to make sweeping progress.
reply
upvoteby Jtsummers3 hours ago|
parent|
[-]
> The first 4 words? "Just ban large prs."

That was a comment written in a particular context, where the original commenter was concerned with large PRs.

>> how can we review gigantic PR generated by AI.

It was not a comment written in a vacuum saying that all PRs should be small (or not large, whatever that means). Though grey-area does provide some reasonable commentary for why it's good to shrink them (easier to roll back, easier to isolate bugs, etc.). Maybe grey-area does mean to ban all large PRs, but that's not evident in this thread where they wrote a response to a specific comment offering their take on how to resolve the problem raised in that first comment.

> You're loosing big swing aggressive efforts to make sweeping progress.

Just a tip: "losing" not "loosing". We loose arrows at our enemies, we let loose the dogs of war, we loosen our purse strings. But we do not "loose big swing aggressive efforts", we "lose big swing aggressive efforts". It's funny that you get it right once, but mix the two up in the very next sentence.

reply
upvoteby nvme0n1p13 hours ago|
parent|
prev|
[-]
It's like responding to "you should wear a seatbelt, statistically they keep you safer in a crash" with "here are two people who got in a crash without a seatbelt and survived"
reply