upvote
Everybody values their own time more than other's.

The fix, imho, is for the reviewers to also use ai to review the code. However, the ultimate responsibility for the outcome(s) should be on the committer - you commit it, you own it, so to speak. If there's an incident, they need to be the one paged in the middle of the night. Bugs resulting from it will land on their desk.

The reviewers aren't a shield/safety net.

reply
Speak for yourself. I highly value other people’s time, to the extent that I should probably value my time higher than I do for my own sake.

Doing something that wastes other people’s time or makes more work for them than necessary makes me feel awful.

I’ve always worked in a way that respects other people’s time and I always tried to make sure I did everything I could to minimize the work I’m asking someone to do for me.

reply
Well its obviously infeasible as during the time of the incident it is not yet known what is wrong and who caused it.

Is it even actually good to get to a point of blaming someone for an incident?

reply
> Everybody values their own time more than other's.

This is false, you’re just oblivious to people who grew up in conditions that would make them that way.

reply
deleted
reply
AI and companies reward sociopathic behavior. When he eventually complains to his boss that his work isn't being merged and it's been done for days/weeks/months that will filter up and look bad on the people holding him up.
reply
At that point then disable merge checks and let them merge without a review. If there is a problem it's on them
reply
This is my current strategy, it's working great. Half the team has been fired for slop and the other half got fired for not doing anything.
reply
I'm sure this person's manager knows that having trouble getting PRs reviewed can (but not always) be a signal of a deeper problem. It could be that no one one the team knows the domain, it could be that no one like the person, but most likely it's that the PRs are frequently bad and no one wants to bother.
reply
deleted
reply
[dead]
reply
Or, I might say, why review the PR. Get Claude to do it? Why do I need to spend my time and attention and this person does not?
reply
Well, what's the solution here, he should ship less stuff?
reply
The solution is that he spends more time scoping the size of the PR so that it’s reviewable and understands the code he’s submitting well enough to have discussions about it. And that he does so human to human so that they can come to mutual understanding.
reply
Less WIP is better for the throughput. If you saturate all the review bandwidth you're just wasting your time creating more PRs, the time would be better spent helping others get their PRs merged.
reply
> Well, what's the solution here, he should ship less stuff?

The solution is in the title - he wants human attention, he needs to demonstrate human effort.

reply
He isn’t shipping anything. Asking for code review is not shipping.

This is the complaint:

> he doesn't make it easy for the team to look at.

He has traded readability for volume. The lack of readability is causing him to ship less. This was a bad trade because the readability is the bottleneck not the code creation. He should improve readability.

reply
>> the readability is the bottleneck not the code creation. He should improve readability.

See this is where I think LLMs can actually improve software engineering. Use them to write better code not more code. The most useful LLM at work so far is the code review bot that occasionally finds things that I missed even with a careful self review and good test coverage.

We should be prompting the LLMs to review our hand written code for security, correctness, style, maintainability, etc., and then use human review for good design and sanity checking. The bots can do things like hold all the C++ correctness rules in their context and apply them sometimes better than even a human expert.

reply
The solution is to merge more of his PRs on the condition that he takes at least partial responsibility for any resulting problems.
reply
That's not how anything works. Even if he says he's going to take responsibility, when the customer call comes in at midnight you're going to be the one fixing his problems.
reply
deleted
reply
The reviewer gets to merge the PR so their name appears on all the great new features and they are credited for them. That would end his unfair behaviour of dumping effort onto other people.

OR - he gets a review for every review he does.

reply